chore(gov): remove governance, rely on web-team instead#8261
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the local GOVERNANCE.md file from the repository and instead points users to the centralized governance document maintained by the web-team. This change consolidates governance documentation in a single location to avoid duplication and maintenance overhead.
Key changes:
- Adds a reference link to the web-team's governance document in the README
- Removes the local GOVERNANCE.md file entirely
- Updates CODEOWNERS to remove the governance file entry
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Adds link to centralized governance document in web-team repository |
| GOVERNANCE.md | Removes entire local governance document (90 lines deleted) |
| .github/CODEOWNERS | Removes GOVERNANCE.md ownership entry as file no longer exists |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8261 +/- ##
==========================================
- Coverage 76.57% 76.56% -0.02%
==========================================
Files 117 117
Lines 9733 9733
Branches 329 329
==========================================
- Hits 7453 7452 -1
- Misses 2278 2279 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
i felt like you already did this 😅 |
|
@nodejs/web-admins can we merge this w/o TSC approval, since the file itself is unchanged, only moved? |
This would make sense to me if https://github.com/nodejs/web-team/blob/main/GOVERNANCE.md was owned by TSC, yes? |
Fixes nodejs/web-team#9.
An alternative to this approach is a governance file that contains the link within it, rather than removing it entirely.