build: skip sscache action on non-main branches#61790
Open
joyeecheung wants to merge 3 commits intonodejs:mainfrom
Open
build: skip sscache action on non-main branches#61790joyeecheung wants to merge 3 commits intonodejs:mainfrom
joyeecheung wants to merge 3 commits intonodejs:mainfrom
Conversation
To reduce cache thrashing.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
marco-ippolito
approved these changes
Feb 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61790 +/- ##
==========================================
- Coverage 89.76% 88.85% -0.91%
==========================================
Files 675 675
Lines 204674 204806 +132
Branches 39330 39262 -68
==========================================
- Hits 183716 181971 -1745
- Misses 13235 15050 +1815
- Partials 7723 7785 +62 🚀 New features to boost your workflow:
|
bnb
approved these changes
Feb 12, 2026
targos
approved these changes
Feb 12, 2026
targos
added
the
author ready
lpinca
approved these changes
Feb 12, 2026
aduh95
reviewed
Feb 13, 2026
aduh95
reviewed
Feb 13, 2026
aduh95
reviewed
Feb 13, 2026
aduh95
added
lts-watch-v20.x
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
reviewed
Feb 17, 2026
aduh95
reviewed
Feb 17, 2026
Comment on lines
+40
to
+41
| CC: ${{ (github.base_ref == 'main' || github.ref_name == 'main') && 'sccache clang-19' || 'clang-19' }} | ||
| CXX: ${{ (github.base_ref == 'main' || github.ref_name == 'main') && 'sccache clang++-19' || 'clang++-19' }} |
Contributor
There was a problem hiding this comment.
Can we apply the same here, to avoid repetition
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reduce cache thrashing.
From a look at the action results, PRs targeting non-main generally don't have a good cache hit rate anyway, so it seems better to just keep it to main where the majority of the volume is:
https://github.com/nodejs/node/actions/runs/21866462915
https://github.com/nodejs/node/actions/runs/21866461713
Refs: #61436