Skip to content

Conversation

@Ms2ger
Copy link

@Ms2ger Ms2ger commented Feb 9, 2026

Notably, the test_blob() helper functions no longer uses FileReader, so tests using them can now run successfully in node.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 9, 2026
@MattiasBuelens MattiasBuelens added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 9, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 9, 2026
@Ms2ger
Copy link
Author

Ms2ger commented Feb 10, 2026

I noticed another bug in the implementation while looking at the remaining failures here, for which I submitted tests upstream. I've added those to this PR as well.

The CI failures seem to be caused by the github outage yesterday.

@Aditi-1400 Aditi-1400 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 10, 2026
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 10, 2026
@github-actions
Copy link
Contributor

Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - test: update FileAPI tests from WPT
   ⚠  - fixup! test: update FileAPI tests from WPT
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/21860435679

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.74%. Comparing base (ae2ffce) to head (4714dbc).
⚠️ Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61750      +/-   ##
==========================================
- Coverage   89.75%   89.74%   -0.01%     
==========================================
  Files         674      675       +1     
  Lines      204416   204642     +226     
  Branches    39285    39322      +37     
==========================================
+ Hits       183472   183666     +194     
- Misses      13227    13262      +35     
+ Partials     7717     7714       -3     

see 52 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@joyeecheung joyeecheung added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Feb 10, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 10, 2026
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants