Skip to content

Conversation

@MoLow
Copy link
Member

@MoLow MoLow commented Jan 28, 2026

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jan 28, 2026
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, how did I miss this before 😵‍💫

🙌

@MoLow
Copy link
Member Author

MoLow commented Jan 28, 2026

Oh wow, how did I miss this before 😵‍💫

All new experimental features evolve one way or another 🫶🏼

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 28, 2026
@MoLow MoLow force-pushed the fix-passing-expect-failure branch 2 times, most recently from d8d31da to 4c510a4 Compare January 28, 2026 17:57
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2026
@nodejs-github-bot
Copy link
Collaborator

@MoLow MoLow force-pushed the fix-passing-expect-failure branch from 4c510a4 to 81d55bf Compare January 28, 2026 18:04
@MoLow
Copy link
Member Author

MoLow commented Jan 28, 2026

@aduh95 thanks for the fast approvals. I changed the behavior a bit to better play when both skip and expectFailure are set

@MoLow MoLow requested a review from aduh95 January 28, 2026 18:15
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.77%. Comparing base (79ddd1b) to head (81d55bf).
⚠️ Report is 100 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61568      +/-   ##
==========================================
+ Coverage   88.53%   89.77%   +1.23%     
==========================================
  Files         704      673      -31     
  Lines      208876   203829    -5047     
  Branches    40330    39173    -1157     
==========================================
- Hits       184937   182980    -1957     
+ Misses      15922    13179    -2743     
+ Partials     8017     7670     -347     
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 97.32% <100.00%> (+0.01%) ⬆️

... and 138 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants