-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
net: add setTypeOfService and getTypeOfService to Socket #61503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Can you add the documentation?
|
Thanks @mcollina , is this ready to be merged? Please let me know if there is anything else you need me to adjust. |
42d5142 to
c0407b2
Compare
|
@mcollina I'm confused by the CI failures. Any ideas? Or just flaky? |
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but there are still a few comments to solve
|
@mcollina likely the renaming ones right?? i have pushed the changes regarding the renaming ones, have a look at it, i was just waiting to see that all ci checks are running properly or not for all platforms. |
|
i have changed the names of files, can you please rerun the ci checks, so i can know if any issue is still there or not?? |
|
i agree that 1 ci failure is caused due to me but it has a valid reason, semantic versioning. i dont know what version to add in the net.md documentation, i am totally unaware of that, kindly guide me that which version should i add here
same for ADDME too below ci failures are flaky |
|
i checked the failing console logs of the ci failures, and thats totally flaky, kindly consider running the ci tests of github actions, and lets moove forward merging. Thank You! |
We can't, let me re-trigger the CI |
but its all flaky, totally unrelated to my changes |
I know, but we can't land when CI is not happy. No worries, your changes will land soon-ish :) |
|
@juanarbol i guess its due to overhead use of the jenkins ci system. you can check each and every logs i have cited them here. its not my code fault its systems fault. Failures:
even unstable build failures are due to the system cant run programs like git
|






this PR implements
socket.setTOS(tos)andsocket.getTOS()innet.Socket. it needed this to support DSCP tagging (QoS) for traffic prioritization, which wasn't previously exposed in the JS API. for the implementation:tcp_wrap.ccto attemptIP_TOSfirst, and fallback toIPV6_TCLASSif that fails. This handles both IPv4 and IPv6 sockets automatically without needing a separate flag.UV_ENOSYSfor now since the headers/implementation differ there.test-net-socket-tos.js) to verify input validation and ensure the values are actually set on supported platforms.Fixes: #61489