deps: update simdutf to 5.0.0 by lemire · Pull Request #52138 · nodejs/node

lemire · 2024-03-18T17:39:50Z

This updates simdutf to version 5.0.0: https://github.com/simdutf/simdutf/releases/tag/v5.0.0

The main reason for this update is to get support for an accelerated Base64 codec (see https://github.com/simdutf/simdutf/?tab=readme-ov-file#base64). This should help with the following issues:

nodejs-github-bot · 2024-03-18T17:39:55Z

Review requested:

@nodejs/security-wg

nodejs-github-bot · 2024-03-18T17:48:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57815/

mhdawson

LGTM, assuming tests pass.

mhdawson · 2024-03-18T17:49:41Z

@lemire I assume this PR is needed versus one generated by the automation as it pulls in a new SemVer major version, right?

lemire · 2024-03-18T17:55:01Z

@mhdawson I used the automated script, but I wanted to explain why I was upgrading simdutf rather than having a silly "this is an automated update".

And you are correct. It is a rather major change. It is fully backward compatible, but adding base64 to simdutf is a big deal in terms of new code.

github-actions · 2024-03-19T01:00:07Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @anonrig.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

anonrig · 2024-03-19T01:00:27Z

I think this pull request (due to the impact) and the pull-request that actually adds base64 should be notable change.

RafaelGSS · 2024-03-19T11:28:42Z

And you are correct. It is a rather major change. It is fully backward compatible, but adding base64 to simdutf is a big deal in terms of new code.

@lemire It means the breaking changes won't affect Node.js? Is it safe to land it as semver-minor instead?

I'm adding semver-major for now just for precaution

lemire · 2024-03-19T12:08:43Z

@RafaelGSS It should not break anything, as we just extended the API. However, having it as semvar-major is fine.

github-actions · 2024-03-19T14:47:10Z

Fast-track has been requested by @lemire. Please 👍 to approve.

nodejs-github-bot · 2024-03-19T14:52:03Z

Commit Queue failed

- Loading data for nodejs/node/pull/52138
✔  Done loading data for nodejs/node/pull/52138
----------------------------------- PR info ------------------------------------
Title      deps: update simdutf to 5.0.0 (#52138)
Author     Daniel Lemire  (@lemire)
Branch     lemire:update_simdutf_to_500 -> nodejs:main
Labels     semver-minor, notable-change, fast-track, needs-ci, dependencies
Commits    1
 - deps: update simdutf to 5.0.0
Committers 1
 - Daniel Lemire 
PR-URL: https://github.com/nodejs/node/pull/52138
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Michael Dawson 
Reviewed-By: Marco Ippolito 
Reviewed-By: Rafael Gonzaga 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52138
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Michael Dawson 
Reviewed-By: Marco Ippolito 
Reviewed-By: Rafael Gonzaga 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 18 Mar 2024 17:39:50 GMT
   ✔  Approvals: 4
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52138#pullrequestreview-1943783643
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/52138#pullrequestreview-1943792964
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/52138#pullrequestreview-1945456310
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/52138#pullrequestreview-1946193109
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 26 more hours to land (or 0 hours if there are 2 more approvals (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-03-18T17:48:14Z: https://ci.nodejs.org/job/node-test-pull-request/57815/
- Querying data for job/node-test-pull-request/57815/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/8345146368

nodejs-github-bot · 2024-03-19T15:12:26Z

Commit Queue failed

- Loading data for nodejs/node/pull/52138
✔  Done loading data for nodejs/node/pull/52138
----------------------------------- PR info ------------------------------------
Title      deps: update simdutf to 5.0.0 (#52138)
Author     Daniel Lemire  (@lemire)
Branch     lemire:update_simdutf_to_500 -> nodejs:main
Labels     semver-minor, notable-change, fast-track, needs-ci, dependencies
Commits    1
 - deps: update simdutf to 5.0.0
Committers 1
 - Daniel Lemire 
PR-URL: https://github.com/nodejs/node/pull/52138
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Michael Dawson 
Reviewed-By: Marco Ippolito 
Reviewed-By: Rafael Gonzaga 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52138
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Michael Dawson 
Reviewed-By: Marco Ippolito 
Reviewed-By: Rafael Gonzaga 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 18 Mar 2024 17:39:50 GMT
   ✔  Approvals: 4
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52138#pullrequestreview-1943783643
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/52138#pullrequestreview-1943792964
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/52138#pullrequestreview-1945456310
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/52138#pullrequestreview-1946193109
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 26 more hours to land (or 0 hours if there are 2 more approvals (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-03-19T14:52:03Z: https://ci.nodejs.org/job/node-test-pull-request/57815/
- Querying data for job/node-test-pull-request/57815/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/8345445920

lemire · 2024-03-19T22:00:38Z

There will have to be an update upstream because, in practice, Node seems to commonly find base64 as UTF-16 strings.

cc @anonrig

nodejs-github-bot · 2024-03-20T17:44:38Z

Landed in f69946b

PR-URL: nodejs#52138 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: #52138 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) #52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492 doc: * update release gpg keyserver (marco-ippolito) #52257 * add release key for marco-ippolito (marco-ippolito) #52257 * add UlisesGascon as a collaborator (Ulises Gascón) #51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) #52618 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127 * (SEMVER-MINOR) support forced exit (Colin Ihrig) #52038 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927 watch: * mark as stable (Moshe Atlow) #52074 PR-URL: TODO

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) #52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492 doc: * update release gpg keyserver (marco-ippolito) #52257 * add release key for marco-ippolito (marco-ippolito) #52257 * add UlisesGascon as a collaborator (Ulises Gascón) #51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) #52618 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127 * (SEMVER-MINOR) support forced exit (Colin Ihrig) #52038 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927 watch: * mark as stable (Moshe Atlow) #52074 PR-URL: #52793

PR-URL: #52138 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) #52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492 doc: * update release gpg keyserver (marco-ippolito) #52257 * add release key for marco-ippolito (marco-ippolito) #52257 * add UlisesGascon as a collaborator (Ulises Gascón) #51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) #52618 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927 watch: * mark as stable (Moshe Atlow) #52074 PR-URL: #52793

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) nodejs#52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) nodejs#52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) nodejs#52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) nodejs#52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) nodejs#51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) nodejs#51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) nodejs#52492 doc: * update release gpg keyserver (marco-ippolito) nodejs#52257 * add release key for marco-ippolito (marco-ippolito) nodejs#52257 * add UlisesGascon as a collaborator (Ulises Gascón) nodejs#51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) nodejs#51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) nodejs#52618 fs: * add stacktrace to fs/promises (翠 / green) nodejs#49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) nodejs#52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) nodejs#52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) nodejs#51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) nodejs#52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) nodejs#51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) nodejs#52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) nodejs#51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) nodejs#51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) nodejs#52127 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) nodejs#51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) nodejs#52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) nodejs#51927 watch: * mark as stable (Moshe Atlow) nodejs#52074 PR-URL: nodejs#52793

deps: update simdutf to 5.0.0

0663357

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Mar 18, 2024

lemire added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2024

lemire requested review from anonrig and joyeecheung March 18, 2024 17:41

anonrig approved these changes Mar 18, 2024

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2024

mhdawson approved these changes Mar 18, 2024

View reviewed changes

lemire added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 18, 2024

anonrig added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 19, 2024

marco-ippolito approved these changes Mar 19, 2024

View reviewed changes

RafaelGSS added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 19, 2024

RafaelGSS added semver-minor PRs that contain new features and should be released in the next minor version. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Mar 19, 2024

RafaelGSS approved these changes Mar 19, 2024

View reviewed changes

lemire added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 19, 2024

lemire added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 19, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 19, 2024

lemire added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 19, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 19, 2024

lemire added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 19, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 20, 2024

nodejs-github-bot merged commit f69946b into nodejs:main Mar 20, 2024

RafaelGSS mentioned this pull request Apr 15, 2024

2024-04-24, Version 22.0.0 (Current) #52505

Merged

marco-ippolito mentioned this pull request May 2, 2024

v20.13.0 proposal #52793

Merged

richardlau mentioned this pull request May 16, 2024

v18.20.3 proposal #53028

Merged

Uh oh!

Conversation

lemire commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 18, 2024

Uh oh!

nodejs-github-bot commented Mar 18, 2024

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

mhdawson commented Mar 18, 2024

Uh oh!

lemire commented Mar 18, 2024

Uh oh!

github-actions bot commented Mar 19, 2024

Uh oh!

anonrig commented Mar 19, 2024

Uh oh!

RafaelGSS commented Mar 19, 2024

Uh oh!

lemire commented Mar 19, 2024

Uh oh!

github-actions bot commented Mar 19, 2024

Uh oh!

nodejs-github-bot commented Mar 19, 2024

Uh oh!

nodejs-github-bot commented Mar 19, 2024

Uh oh!

lemire commented Mar 19, 2024

Uh oh!

nodejs-github-bot commented Mar 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lemire commented Mar 18, 2024 •

edited

Loading