Open
Conversation
cclauss
force-pushed
the
npm_--msvs-version__and_--python
branch
8 times, most recently
from
e6fc058 to
f847da5
Compare
lukekarrys
reviewed
Feb 4, 2026
lukekarrys
reviewed
Feb 4, 2026
cclauss
force-pushed
the
npm_--msvs-version__and_--python
branch
from
1a17da7 to
7830684
Compare
cclauss
force-pushed
the
npm_--msvs-version__and_--python
branch
from
7830684 to
eecb0d9
Compare
gengjiawen
reviewed
Feb 27, 2026
| matrix: | ||
| include: | ||
| - os: windows-2022 | ||
| msvs-version: 2022 |
Member
There was a problem hiding this comment.
all 3 msvs-version can be removed since it no longer used.
gengjiawen
reviewed
Feb 27, 2026
| - name: Run Node tests | ||
| shell: pwsh | ||
| run: npm run test --python="${env:pythonLocation}\\python.exe" --msvs-version="${{ matrix.msvs-version }}" | ||
| shell: bash # Building wasm on Windows requires using make generator, it only works in bash |
Member
There was a problem hiding this comment.
tests.yml already use bash. Maybe this stays on pwsh, since bash maybe available on windows machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3260
npmv12 drops support for--msvs-version=[year]and--python=[path]#3260Checklist
npm install && npm run lint && npm testpassesDescription of change