Skip to content

Add Date::New overload for a std::chrono::system_clock::time_point #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cacharle wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Draft

Add Date::New overload for a std::chrono::system_clock::time_point #1705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions napi-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
#endif // NAPI_HAS_THREADS
#include <type_traits>
#include <utility>
#if __cplusplus >= 201103L
#include <chrono>
#endif

#if defined(__clang__) || defined(__GNUC__)
#define NAPI_NO_SANITIZE_VPTR __attribute__((no_sanitize("vptr")))
Expand Down Expand Up @@ -1199,6 +1202,15 @@ inline Date Date::New(napi_env env, double val) {
return Date(env, value);
}

#if __cplusplus >= 201103L
inline Date Date::New(napi_env env, std::chrono::system_clock::time_point tp) {
using namespace std::chrono;
auto ms = static_cast<double>(
duration_cast<milliseconds>(tp.time_since_epoch()).count());
return Date::New(env, ms);
}
#endif

inline void Date::CheckCast(napi_env env, napi_value value) {
NAPI_CHECK(value != nullptr, "Date::CheckCast", "empty value");

Expand Down
6 changes: 6 additions & 0 deletions napi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,12 @@ class Date : public Value {
double value ///< Number value
);

/// Creates a new Date value from a std::chrono::system_clock::time_point.
static Date New(
napi_env env, ///< Node-API environment
std::chrono::system_clock::time_point tp ///< Time point value
);

static void CheckCast(napi_env env, napi_value value);

Date(); ///< Creates a new _empty_ Date instance.
Expand Down