Skip to content

wp_publish_post not checking for unique post slugs #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nirav7707 wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

wp_publish_post not checking for unique post slugs #2

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0bb0369
Test: wp_publish_post provides unique slug to post
nirav7707 Apr 25, 2022
0cd439a
Refect: change wp_insert_post with factory object
nirav7707 Apr 26, 2022
96c4d9b
Merge branch 'trunk' of github.com:WordPress/wordpress-develop into t…
nirav7707 Apr 26, 2022
a735bc5
Merge branch 'trunk' into test/wp_publish_post
nirav7707 Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions tests/phpunit/tests/post.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,55 @@ public function test_unstick_post_with_non_sticky_post_id_does_not_update_option
}

/**
* Ensure updated post have a different slug then already publish post with same name.
*
* @ticket 50447
* @covers ::wp_publish_post
*/
public function test_updated_draft_post_have_unique_slug_from_publish_post_with_same_title() {

// Publish post metainfo.
$post = array(
'post_name' => 'test',
'post_title' => 'test',
'post_status' => 'publish',
);

// Add post.
$post_id = self::factory()->post->create( $post );

// Testcase for publish post with $post_id
$post_object = get_post( $post_id );
$this->assertSame( 'test', $post_object->post_title );
$this->assertSame( 'test', $post_object->post_name );

// Draft post metainfo.
$draft_post = array(
'post_title' => 'test',
'post_status' => 'draft',
'post_name' => 'test'
);

// Add draft post.
$draft_post_id = self::factory()->post->create( $draft_post );

// Testcase for draft post with $draft_post_id.
$post_object = get_post( $draft_post_id );
$this->assertSame( 'test', $post_object->post_title );
$this->assertSame( 'draft', $post_object->post_status );

// Update draft post.
wp_publish_post( $draft_post_id );

// Testcase for updated draft post.
$post_object = get_post( $draft_post_id );
$this->assertSame( 'test', $post_object->post_title );
$this->assertSame( 'publish', $post_object->post_status );
$this->assertNotSame( 'test', $post_object->post_name );
$this->assertSame( wp_unique_post_slug($post_object->post_name, $post_object->ID, $post_object->post_status, $post_object->post_type, $post_object->post_parent), $post_object->post_name );
}

/**
* Check if post supports block editor.
*
* @ticket 51819
Expand Down