-
Notifications
You must be signed in to change notification settings - Fork 99
Updates to nirfsg method and parameter names and defaults #2145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2145 +/- ##
==========================================
+ Coverage 90.01% 90.09% +0.07%
==========================================
Files 71 71
Lines 18637 18643 +6
==========================================
+ Hits 16776 16796 +20
+ Misses 1861 1847 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Can you remind me why there's no self_test system test? |
Co-authored-by: Jay Fitzgerald <34140133+ni-jfitzger@users.noreply.github.com>
I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
nametowaveform_nameinclear_arb_waveformandselect_arb_waveformto be consistent with other waveform methodsget_self_calibration_last_date_and_timetoget_self_cal_last_date_and_timeto be consistent with other MI driversmoduleparameter inget_self_cal_last_date_and_timeandget_self_calibration_temperaturemethods to align with documentation and allow duck-typingself_testto not have any parameters aligning with other MI driversself_test.List issues fixed by this Pull Request below, if any.
None
What testing has been done?
Only build is tested to work. System tests were not run after the renaming.