Skip to content

Fix len parameter handling: Unit tests for gRPC and session #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
batzuu wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix len parameter handling: Unit tests for gRPC and session #2140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
638 changes: 321 additions & 317 deletions generated/nifake/nifake/nifake_pb2.py
View file
Open in desktop

Large diffs are not rendered by default.

33 changes: 33 additions & 0 deletions generated/nifake/nifake/nifake_pb2_grpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,11 @@ def __init__(self, channel):
request_serializer=nifake__pb2.MultipleArraysSameSizeRequest.SerializeToString,
response_deserializer=nifake__pb2.MultipleArraysSameSizeResponse.FromString,
)
self.MultipleArraysDifferentSize = channel.unary_unary(
'/nifake_grpc.NiFake/MultipleArraysDifferentSize',
request_serializer=nifake__pb2.MultipleArraysDifferentSizeRequest.SerializeToString,
response_deserializer=nifake__pb2.MultipleArraysDifferentSizeResponse.FromString,
)
self.OneInputFunction = channel.unary_unary(
'/nifake_grpc.NiFake/OneInputFunction',
request_serializer=nifake__pb2.OneInputFunctionRequest.SerializeToString,
Expand Down Expand Up @@ -660,6 +665,12 @@ def MultipleArraysSameSize(self, request, context):
context.set_details('Method not implemented!')
raise NotImplementedError('Method not implemented!')

def MultipleArraysDifferentSize(self, request, context):
"""Missing associated documentation comment in .proto file."""
context.set_code(grpc.StatusCode.UNIMPLEMENTED)
context.set_details('Method not implemented!')
raise NotImplementedError('Method not implemented!')

def OneInputFunction(self, request, context):
"""Missing associated documentation comment in .proto file."""
context.set_code(grpc.StatusCode.UNIMPLEMENTED)
Expand Down Expand Up @@ -1219,6 +1230,11 @@ def add_NiFakeServicer_to_server(servicer, server):
request_deserializer=nifake__pb2.MultipleArraysSameSizeRequest.FromString,
response_serializer=nifake__pb2.MultipleArraysSameSizeResponse.SerializeToString,
),
'MultipleArraysDifferentSize': grpc.unary_unary_rpc_method_handler(
servicer.MultipleArraysDifferentSize,
request_deserializer=nifake__pb2.MultipleArraysDifferentSizeRequest.FromString,
response_serializer=nifake__pb2.MultipleArraysDifferentSizeResponse.SerializeToString,
),
'OneInputFunction': grpc.unary_unary_rpc_method_handler(
servicer.OneInputFunction,
request_deserializer=nifake__pb2.OneInputFunctionRequest.FromString,
Expand Down Expand Up @@ -2026,6 +2042,23 @@ def MultipleArraysSameSize(request,
options, channel_credentials,
insecure, call_credentials, compression, wait_for_ready, timeout, metadata)

@staticmethod
def MultipleArraysDifferentSize(request,
target,
options=(),
channel_credentials=None,
call_credentials=None,
insecure=False,
compression=None,
wait_for_ready=None,
timeout=None,
metadata=None):
return grpc.experimental.unary_unary(request, target, '/nifake_grpc.NiFake/MultipleArraysDifferentSize',
nifake__pb2.MultipleArraysDifferentSizeRequest.SerializeToString,
nifake__pb2.MultipleArraysDifferentSizeResponse.FromString,
options, channel_credentials,
insecure, call_credentials, compression, wait_for_ready, timeout, metadata)

@staticmethod
def OneInputFunction(request,
target,
Expand Down
13 changes: 13 additions & 0 deletions generated/nifake/nifake/unit_tests/test_grpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,19 @@ def test_multiple_arrays_same_size_none_input(self):
values4=None,
)

def test_multiple_arrays_different_size(self):
library_func = 'MultipleArraysDifferentSize'
response_object = self._set_side_effect(library_func)
values_array = [1.1, 2.2, 3.3]
data_array = [10, 20, 30, 40, 50]
interpreter = self._get_initialized_stub_interpreter()
assert interpreter.multiple_arrays_different_size(values_array, data_array) is None # no outputs
self._assert_call(library_func, response_object).assert_called_once_with(
vi=GRPC_SESSION_OBJECT_FOR_TEST,
values_array=values_array,
data_array=data_array,
)

def test_multiple_arrays_same_size_wrong_size(self):
library_func = 'MultipleArraysSameSize'
# grpc-device server checks this server-side and errors with ::grpc::INVALID_ARGUMENT
Expand Down
8 changes: 8 additions & 0 deletions generated/nifake/nifake/unit_tests/test_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,6 +699,14 @@ def test_multiple_arrays_same_size_wrong_size_4(self):
except ValueError:
pass

def test_multiple_arrays_different_size(self):
values_array = [1.1, 2.2, 3.3]
data_array = [10, 20, 30, 40, 50]
self.patched_library_interpreter.multiple_arrays_different_size.side_effect = [None]
with nifake.Session('dev1') as session:
assert session.multiple_arrays_different_size(values_array, data_array) is None
self.patched_library_interpreter.multiple_arrays_different_size.assert_called_once_with(values_array, data_array)

def test_get_cal_date_time(self):
month = 12
day = 30
Expand Down
11 changes: 11 additions & 0 deletions src/nifake/metadata/nifake.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ service NiFake {
rpc InitWithOptions(InitWithOptionsRequest) returns (InitWithOptionsResponse);
rpc MultipleArrayTypes(MultipleArrayTypesRequest) returns (MultipleArrayTypesResponse);
rpc MultipleArraysSameSize(MultipleArraysSameSizeRequest) returns (MultipleArraysSameSizeResponse);
rpc MultipleArraysDifferentSize(MultipleArraysDifferentSizeRequest) returns (MultipleArraysDifferentSizeResponse);
rpc OneInputFunction(OneInputFunctionRequest) returns (OneInputFunctionResponse);
rpc ParametersAreMultipleTypes(ParametersAreMultipleTypesRequest) returns (ParametersAreMultipleTypesResponse);
rpc PoorlyNamedSimpleFunction(PoorlyNamedSimpleFunctionRequest) returns (PoorlyNamedSimpleFunctionResponse);
Expand Down Expand Up @@ -545,6 +546,16 @@ message MultipleArraysSameSizeResponse {
int32 status = 1;
}

message MultipleArraysDifferentSizeRequest {
nidevice_grpc.Session vi = 1;
repeated double values_array = 2;
repeated sint32 data_array = 3;
}

message MultipleArraysDifferentSizeResponse {
int32 status = 1;
}

message OneInputFunctionRequest {
nidevice_grpc.Session vi = 1;
sint32 a_number = 2;
Expand Down
13 changes: 13 additions & 0 deletions src/nifake/unit_tests/test_grpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,19 @@ def test_multiple_arrays_same_size_none_input(self):
values4=None,
)

def test_multiple_arrays_different_size(self):
library_func = 'MultipleArraysDifferentSize'
response_object = self._set_side_effect(library_func)
values_array = [1.1, 2.2, 3.3]
data_array = [10, 20, 30, 40, 50]
interpreter = self._get_initialized_stub_interpreter()
assert interpreter.multiple_arrays_different_size(values_array, data_array) is None # no outputs
self._assert_call(library_func, response_object).assert_called_once_with(
vi=GRPC_SESSION_OBJECT_FOR_TEST,
values_array=values_array,
data_array=data_array,
)

def test_multiple_arrays_same_size_wrong_size(self):
library_func = 'MultipleArraysSameSize'
# grpc-device server checks this server-side and errors with ::grpc::INVALID_ARGUMENT
Expand Down
8 changes: 8 additions & 0 deletions src/nifake/unit_tests/test_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,6 +699,14 @@ def test_multiple_arrays_same_size_wrong_size_4(self):
except ValueError:
pass

def test_multiple_arrays_different_size(self):
values_array = [1.1, 2.2, 3.3]
data_array = [10, 20, 30, 40, 50]
self.patched_library_interpreter.multiple_arrays_different_size.side_effect = [None]
with nifake.Session('dev1') as session:
assert session.multiple_arrays_different_size(values_array, data_array) is None
self.patched_library_interpreter.multiple_arrays_different_size.assert_called_once_with(values_array, data_array)

def test_get_cal_date_time(self):
month = 12
day = 30
Expand Down