Topics for a bunch of SV related modules#10113
Merged
nvnieuwk merged 10 commits intonf-core:masterfrom Feb 23, 2026
Merged
Conversation
Joon-Klaps
approved these changes
Feb 19, 2026
Contributor
Joon-Klaps
left a comment
Joon-Klaps
left a comment
There was a problem hiding this comment.
Dunno why you have in your tests a versions_ if this wasn't intentional, double check if it was, LGTM!
| { assert snapshot( | ||
| file(process.out.npz[0][1]).name, | ||
| process.out.versions | ||
| process.out.findAll { it.key.startsWith("versions_") } |
Contributor
Author
There was a problem hiding this comment.
Ah it's the same as versions, the emit is always versions_<tool> so it just does the same thing :)
| { assert process.success }, | ||
| { assert snapshot( | ||
| process.out.versions, | ||
| process.out.findAll { it.key.startsWith("versions_") }, |
| { assert process.success }, | ||
| { assert snapshot( | ||
| process.out.versions, | ||
| process.out.findAll { it.key.startsWith("versions_") }, |
Contributor
There was a problem hiding this comment.
did you mess up ur global replace?
Contributor
Author
There was a problem hiding this comment.
I guess I manually typed these 😁 they're similar in funcionality as you can see in the snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda