Fix IME composition handling in option inputs#3183
Merged
Chartman123 merged 1 commit intonextcloud:mainfrom Feb 26, 2026
Merged
Fix IME composition handling in option inputs#3183Chartman123 merged 1 commit intonextcloud:mainfrom
Chartman123 merged 1 commit intonextcloud:mainfrom
Conversation
Collaborator
|
@don9x2E thanks for your fix :) please sign-off your commit |
Signed-off-by: don9x2E <revan@kakao.com>
8916840 to
9ee83f1
Compare
Chartman123
approved these changes
Feb 26, 2026
Collaborator
Chartman123
left a comment
There was a problem hiding this comment.
Looks good from my point of view
susnux
approved these changes
Feb 26, 2026
Collaborator
|
/backport to stable5.2 |
Contributor
Author
|
Follow-up update pushed in commit 4b8ae6d. What was added after the approved IME patch:
This resolves the remaining Korean IME edge-case observed in real usage. |
Contributor
Author
|
Design proposal only (no code change): restoring auto-create safely If we want to bring back auto-create for the local option row later, a safer staged approach is:
Acceptance criteria for any auto-create restoration:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR now includes a follow-up fix after the initial IME handling patch.
Enter(after composition ends) or explicit+button clickWhy this follow-up was needed
The previous attempt improved composition guards, but real Korean IME usage still hit edge cases where input-driven side effects could trigger unexpectedly in the local option row.
In practice, automatic creation on input was still risky under composition timing differences across browsers/IME implementations.
Behavioral change and trade-off
The local empty option row no longer auto-creates an option purely from input events.
Instead, creation is explicit (
Enteror+button).This slightly reduces automation, but removes IME race/side-effect paths and gives deterministic behavior for CJK input users.
Repro (before)
Verification (after)
Entercreates exactly one option+button creates exactly one option