When uploading a single file, offer input field to change file name #16215
+238
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This streamlines the upload from files, e.g. from email attachments. Closes nextcloud#9215. The approach via the listener mFileDisplayNameTransformer was chosen because this allows a potential extension to multiple files (with multiple input fields). Alternatively, ReceiveExternalFilesActivity#uploadFile() could've been used, which requires the storage to a temporary file first. nextFocusForward and nextFocusDown are both needed to support navigation with the Tab key as well as the Enter key Signed-off-by: Philipp Hasper <vcs@hasper.info>
This streamlines the renaming and speeds up the process. Signed-off-by: Philipp Hasper <vcs@hasper.info>
Making the Permission keys in OCFile public is a good change anyways - why should these magic strings be private after all? This only invites duplication and hinders maintenance.
PhilLab
commented
Dec 29, 2025
| .check(matches(withSelectedText(thirdFileName))) | ||
|
|
||
| /* | ||
| * TODO - NOMERGE: check that the new name is actually used during the upload! |
Contributor
Author
There was a problem hiding this comment.
WIP, because
- this verification is missing
- The following lines uncover a bug in the implementation which needs to be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This streamlines the upload from files, e.g. from email attachments.
Closes #9215.
The approach via the listener mFileDisplayNameTransformer was chosen because this allows a potential extension to multiple files (with multiple input fields). Alternatively, ReceiveExternalFilesActivity#uploadFile() could've been used, which requires the storage to a temporary file first.
nextFocusForward and nextFocusDown are both needed to support navigation with the Tab key as well as the Enter key