사다리타기 - Step2 리뷰요청 드립니다. #2442
Open
사다리타기 - Step2 리뷰요청 드립니다. #2442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- LineStrategy 인터페이스 - RandomLineStrategy 랜덤 출력 구현체
- List<Line>을 가지는 Ladder 클래스
- Ladder과 Names를 조합한 클래스
- Ladder -> Lines - LadderGame -> Ladder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요!
사다리타기 2단계 미션 진행해보았습니다.
Name -> Names
Height
Line -> Lines
Ladder
작은 단위부터 큰 단위로 올라가면서 작업해보았습니다.
Lines / Ladder / LadderGame으로 고민을 했는데,
Lines와 Names를 Ladder가 가지고 있는게 가장 적합해보아서 마지막에 클래스명을 수정하였습니다.
피드백 주시면, 확인해보겠습니다!
감사합니다!