[NTC-4957] Fixed parsing Palo banners that start on the same line #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joewesch
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
Contributor
|
Can you add a |
jeffkala
reviewed
Jan 27, 2026
tests/unit/mock/config/parser/base/paloalto_panos/paloalto_banner_same_line_received.py
Show resolved
Hide resolved
itdependsnetworks
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #780
This PR changes the logic a bit when dealing with Palo Alto banners that start on the same line as
login-banner. The existing test only tests if they start with an empty line:But a banner isn't required to have a blank line on the first line.