fix: add missing SRV dnsRecord properties#371
Open
robotblake wants to merge 1 commit intonetlify:masterfrom
Open
fix: add missing SRV dnsRecord properties#371robotblake wants to merge 1 commit intonetlify:masterfrom
robotblake wants to merge 1 commit intonetlify:masterfrom
Conversation
|
✔️ Deploy Preview for open-api ready! 🔨 Explore the source changes: 5c2575e 🔍 Inspect the deploy log: https://app.netlify.com/sites/open-api/deploys/61f8652e16803c0008f3e564 😎 Browse the preview: https://deploy-preview-371--open-api.netlify.app |
SRV records contain a `weight` property and a `port` property. These properties are present in the `dnsRecordCreate` definition but not in the `dnsRecord` definition even though they are returned by the API.
robotblake
force-pushed
the
dns-missing-props
branch
from
c0ecab4 to
5c2575e
Compare
robotblake
changed the title
rstavchansky
added
the
type: chore
Contributor
|
@robotblake mind rebasing this PR to fix conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SRV records contain a
weightproperty and aportproperty. These properties are present in thednsRecordCreatedefinition but not in thednsRecorddefinition even though they are returned by the API.