fix(http-agent): improve type safety and fix proxy agent implementation#7889
fix(http-agent): improve type safety and fix proxy agent implementation#7889
Conversation
This change improves the type safety of the http-agent module by: - Removing the `HttpsProxyAgentWithCA` workaround class. - Using the `HttpsProxyAgent` class directly from the `https-proxy-agent` library. - Correctly typing the `getAgent` and `tryGetAgent` functions. This change also fixes a type error in `base-command.ts` by correctly passing the `HttpsProxyAgent` object to the `NetlifyAPI` constructor via the `fetchOptions` property. Co-authored-by: serhalp <1377702+serhalp@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This change improves the type safety of the http-agent module by removing the HttpsProxyAgentWithCA workaround class and using the HttpsProxyAgent class directly. It also fixes the type error in base-command.ts by correctly passing the HttpsProxyAgent object to the NetlifyAPI constructor.
PR created automatically by Jules for task 5307340822313006781 started by @serhalp