Geocodio provides country and state codes rather than names#364
Open
idpaterson wants to merge 1 commit intonchaulet:mainfrom
Open
Geocodio provides country and state codes rather than names#364idpaterson wants to merge 1 commit intonchaulet:mainfrom
idpaterson wants to merge 1 commit intonchaulet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change, the
countryandstategeocoding result fields were populated with country and state codes from the API. This pull request usescountryCodeandstateCoderespectively. Geocodio API docsPersonally, I am passing node-geocoder results through a normalization phase using ISO 3166-2 data to map codes to names and vice versa with the expectation that the
country,countryCode,state, andstateCodeare not used consistently. Certainly not urgent to introduce a breaking change, hopefully others using Geocodio have been doing something similar.