Fix duplicate DMX values in virtual channel parsing with proper forwa… #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rd/backward adjustment logic. Simplify DMX value conversion clamping logic in XmlFileHelper
ILane-VW
reviewed
Dec 16, 2025
ILane-VW
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix duplicate DMX value handling for virtual channels
Added logic to ensure unique DMXFrom values when parsing channel sets
for virtual channels with recalculated DMX values (32-bit to 16-bit).
Implements duplicate detection with forward increment and cascading
backward decrement fallback to maintain valid DMX ranges.