Add NoFeature exception #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adragnevVW
approved these changes
Nov 12, 2025
AndriiVoitenko
requested changes
Nov 19, 2025
| bool alreadyExists = false; | ||
| GdtfDmxModePtr mode = dmxChnl->GetParentMode(); | ||
| // Allow NoFeature attributes to be linked multiple times to the same geometry | ||
| bool isNoFeatureAttribute = (attrPtr == fNoFeature) || (attributeName.EqualNoCase("NoFeature")); |
Collaborator
There was a problem hiding this comment.
we have also Dummy attribute :)
Collaborator
Author
There was a problem hiding this comment.
And Dummy attributes can be linked multiple times to the same geometry?
Collaborator
Author
There was a problem hiding this comment.
I will make a separate change, branch issue because for this we need to make changes in the FB as well, since there is no logic there for Dummy attributes to be connected multiple times to the same geometry.
AndriiVoitenko
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Allow NoFeature attributes to be linked multiple times to the same geometry and to not throw error.