Resolution added #127
Closed
Resolution added #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adragnevVW
reviewed
Nov 11, 2025
adragnevVW
approved these changes
Nov 11, 2025
AndriiVoitenko
requested changes
Nov 19, 2025
adragnevVW
approved these changes
Nov 21, 2025
Contributor
|
This change can be closed because it broke the unit tests. This has been fixed a different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
Added logic to exchange and extract the resolution from the XML file so that we can get the resolution of the virtual DMX channels. This logic is needed because until now the resolution was calculated from the offsets, but virtual channels do not have offsets.
Test files have also been added.