multiversx-chain-vm-executor dependnecy simplified, feature removed #87
+3
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR simplifies the dependency management for multiversx-chain-vm-executor by removing the feature flag complexity and using a workspace-level patch instead.
Changes:
- Removed conditional compilation features that toggled between local and published versions of the executor interface
- Simplified dependency declaration to use only the version specification
- Added workspace-level
[patch.crates-io]to redirect the dependency to the local path during development
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vm-executor-wasmer/src/lib.rs | Removed conditional feature flags and now unconditionally exports multiversx_chain_vm_executor as executor_interface |
| vm-executor-wasmer/Cargo.toml | Removed [features] section and optional dependency configurations, simplified to a single version-based dependency |
| Cargo.toml | Added [patch.crates-io] section to redirect the crates.io dependency to the local workspace path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good solution, but cannot be applied on a hotfix, needs a minor release.