add metering for bulk memory opcodes #79
Open
+825
−361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
approved these changes
Aug 20, 2025
andrei-marinica
approved these changes
Aug 20, 2025
andrei-marinica
requested changes
Aug 20, 2025
| Operator::Loop { .. } => Some(opcode_cost.opcode_loop), | ||
| Operator::MemoryGrow { .. } => Some(opcode_cost.opcode_memorygrow), | ||
| Operator::MemorySize { .. } => Some(opcode_cost.opcode_memorysize), | ||
| Operator::MemoryCopy { .. } => Some(opcode_cost.opcode_memorycopy), |
Contributor
There was a problem hiding this comment.
We need proper opcode check versioning.
I will be adding it soon.
There was a problem hiding this comment.
I do not think we need. Like we might add some opcodes once per year, there is no need for that. SpaceVM can treat activations, there is no need to complicated the executor.
sasurobert
reviewed
Aug 21, 2025
| Operator::Loop { .. } => Some(opcode_cost.opcode_loop), | ||
| Operator::MemoryGrow { .. } => Some(opcode_cost.opcode_memorygrow), | ||
| Operator::MemorySize { .. } => Some(opcode_cost.opcode_memorysize), | ||
| Operator::MemoryCopy { .. } => Some(opcode_cost.opcode_memorycopy), |
There was a problem hiding this comment.
I do not think we need. Like we might add some opcodes once per year, there is no need for that. SpaceVM can treat activations, there is no need to complicated the executor.
vm-executor/src/opcode_check_used.rs
Outdated
| impl OpcodeCheckUsed { | ||
| pub fn from_value(value: u32) -> Option<Self> { | ||
| match value { | ||
| 0 => Some(Self::MemoryCopy), |
There was a problem hiding this comment.
this is not good. like we would need the full set here. to be easily usable from spaceVM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.