Draft
Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ce4bf53 to
d844dfe
Compare
d844dfe to
5dd5f3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3865
Fixes #3951
Closes #3853
Smaller and more flexible alternative to #3954. This explicitly supports object
itemswith primitivevalue.<Combobox.Root>needs to know what is passed to<Combobox.Item item={...}>ahead of time regarding the shape ofitems. e.g.valuecould be a primitivestringornumber, or the whole item object. This new propgetValueFromItemlets it know explicitly.This can't be inferred automatically except in two cases:
{ value, label }is the shape of theitemsobjectsdefaultValue/valuearen'tnullgetValueFromItemsupports arbitrary object shapes and the initialnullvalue.<Combobox.Root>will error ifgetValueFromItemis missing anvalue/defaultValuedon't match the shape ofitems:This does require synchronizing
<Combobox.Item value={...}andgetValueFromItemtogether. I added a wrapper example in the spec file.The
getValueFromItemname is differentiated from the other mappers (itemToStringValue,itemToStringLabel) as those ones operate on item values, not item objects.