[all components] Add visually hidden close button support with improved modal focus trapping#4084
Open
atomiks wants to merge 1 commit intomui:masterfrom
Open
[all components] Add visually hidden close button support with improved modal focus trapping#4084atomiks wants to merge 1 commit intomui:masterfrom
atomiks wants to merge 1 commit intomui:masterfrom
Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
54dd561 to
53a0448
Compare
53a0448 to
82fa23c
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
visuallyHiddenis a prop for ergonomics for non-Tailwind use and isn't strictly required; Tailwind already has"sr-only"Closes #2722
Closes #3693 (for modal popups with close buttons.
finalFocusis the preferred way to restore focus somewhere when the trigger gets removed as the current method is quite disorienting to screen readers anyway.)New close parts:
Focus trap:
Relevant combobox demos updated to use the
Closepart at the end of the list to escape it