Skip to content

Make @property annotations PHPStan-compatible #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyk merged 1 commit into from
Dec 24, 2025
Merged

Make @property annotations PHPStan-compatible #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Supporting/FileMakerRelation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
*
* @package INTER-Mediator\FileMakerServer\RESTAPI
* @link https://github.com/msyk/FMDataAPI GitHub Repository
* @property string $<<field_name>> The field value named as the property name.
* @property FileMakerRelation $<<portal_name>> FileMakerRelation object associated with the property name.
* The table occurrence name of the portal can be the 'portal_name,' and also the object name of the portal.
* @property string $fieldName The field value named as the property name accessed via __get().
* @property FileMakerRelation $portalName A FileMakerRelation object associated with the property name accessed via __get().
* The table occurrence name of the portal can be the 'portalName', and also the object name of the portal.
* @version 36
* @author Masayuki Nii <nii@msyk.net>
* @copyright 2017-2024 Masayuki Nii (Claris FileMaker is registered trademarks of Claris International Inc. in the U.S. and other countries.)
Expand Down Expand Up @@ -80,7 +80,7 @@
$this->dataInfo = $infoData;
$this->result = $result;
$this->errorCode = $errorCode;
$this->portalName = $portalName;

Check failure on line 83 in src/Supporting/FileMakerRelation.php

View workflow job for this annotation

GitHub Actions / Run Phan 

PhanTypeMismatchPropertyProbablyReal Assigning $portalName of type null|string to property but \INTERMediator\FileMakerServer\RESTAPI\Supporting\FileMakerRelation->portalName is \INTERMediator\FileMakerServer\RESTAPI\Supporting\FileMakerRelation (no real type) (the inferred real assigned type has nothing in common with the declared phpdoc property type)
$this->restAPI = $provider;
if ($errorCode === 0 && $portalName && is_array($infoData)) {
foreach ($infoData as $pdItem) {
Expand Down Expand Up @@ -152,7 +152,7 @@
*/
public function setPortalName(string $name): void
{
$this->portalName = $name;

Check failure on line 155 in src/Supporting/FileMakerRelation.php

View workflow job for this annotation

GitHub Actions / Run Phan 

PhanTypeMismatchPropertyProbablyReal Assigning $name of type string to property but \INTERMediator\FileMakerServer\RESTAPI\Supporting\FileMakerRelation->portalName is \INTERMediator\FileMakerServer\RESTAPI\Supporting\FileMakerRelation (no real type) (the inferred real assigned type has nothing in common with the declared phpdoc property type)
}

/**
Expand Down Expand Up @@ -271,7 +271,7 @@
}
$value = new FileMakerRelation(
$this->data[$num], $dataInfo, ($this->result == "PORTAL") ? "PORTALRECORD" : "RECORD",
$this->errorCode, $this->portalName, $this->restAPI);

Check failure on line 274 in src/Supporting/FileMakerRelation.php

View workflow job for this annotation

GitHub Actions / Run Phan 

PhanTypeMismatchArgument Argument 5 ($portalName) is $this->portalName of type \INTERMediator\FileMakerServer\RESTAPI\Supporting\FileMakerRelation|\Iterator|\Traversable|iterable but \INTERMediator\FileMakerServer\RESTAPI\Supporting\FileMakerRelation::__construct() takes null|string defined at src/Supporting/FileMakerRelation.php:72
}
return $value;
}
Expand Down Expand Up @@ -422,7 +422,7 @@
}
break;
case "PORTALRECORD":
$convinedName = "{$this->portalName}::{$fieldName}";

Check failure on line 425 in src/Supporting/FileMakerRelation.php

View workflow job for this annotation

GitHub Actions / Run Phan 

PhanTypeSuspiciousStringExpression Suspicious type \INTERMediator\FileMakerServer\RESTAPI\Supporting\FileMakerRelation of a variable or expression $this->portalName used to build a string. (Expected type to be able to cast to a string)
if (isset($this->data->$fieldName)) {
$value = $this->data->$fieldName;
} elseif (isset($this->data->$convinedName)) {
Expand Down Expand Up @@ -551,7 +551,7 @@
$result = ($this->result == "PORTAL") ? "PORTALRECORD" : "RECORD";
$portalName = $this->portalName;
$value = new FileMakerRelation($this->data[$this->pointer], $dataInfo, $result,
$this->errorCode, $portalName, $this->restAPI);

Check failure on line 554 in src/Supporting/FileMakerRelation.php

View workflow job for this annotation

GitHub Actions / Run Phan 

PhanTypeMismatchArgument Argument 5 ($portalName) is $portalName of type \INTERMediator\FileMakerServer\RESTAPI\Supporting\FileMakerRelation|\Iterator|\Traversable|iterable but \INTERMediator\FileMakerServer\RESTAPI\Supporting\FileMakerRelation::__construct() takes null|string defined at src/Supporting/FileMakerRelation.php:72
}
break;
case "RECORD":
Expand Down
Loading