Skip to content

Fix SolidJS not being found.#964

Merged
kixelated merged 1 commit intomainfrom
fix-solid-js
Feb 15, 2026
Merged

Fix SolidJS not being found.#964
kixelated merged 1 commit intomainfrom
fix-solid-js

Conversation

@kixelated
Copy link
Collaborator

The devDependencies are weird because moq/demo sources the raw files, not the compiled files.

The devDependencies are weird because moq/demo sources the raw files,
not the compiled files.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 14, 2026

Walkthrough

The js/hang-demo/package.json file was updated to add a descriptive comment field explaining devDependency usage and introduce two new devDependencies: solid-element and solid-js. These additions are utilized when resolving raw TSX files from workspace packages but are not required when consuming published npm packages. The changes consist of three new lines with no removals and do not modify any exported or public API declarations.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix SolidJS not being found' is directly related to the main change, which adds solid-js and solid-element as devDependencies to resolve a SolidJS discovery issue.
Description check ✅ Passed The description 'The devDependencies are weird because moq/demo sources the raw files, not the compiled files' is related to the changeset, explaining the rationale for adding the new devDependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-solid-js

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

"@moq/watch": "workspace:^",
"@moq/publish": "workspace:^"
},
"//devDependencies": "solid-js and solid-element are only needed because Vite resolves raw .tsx source from workspace packages. They are NOT needed when using @moq/watch and @moq/publish as published npm packages.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never seen this way of commenting in JSON before, very cool!

@kixelated kixelated merged commit 8307207 into main Feb 15, 2026
1 check passed
@kixelated kixelated deleted the fix-solid-js branch February 15, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants