chore: do some todos (@Leonabcd123)

backend/src/utils/error.ts

@@ -8,18 +8,16 @@ type FirebaseErrorParent = {
   errorInfo: FirebaseError;
 };
 
-// oxlint-disable-next-line no-explicit-any
-export function isFirebaseError(err: any): err is FirebaseErrorParent {
+export function isFirebaseError(err: unknown): err is FirebaseErrorParent {
   return (
+    err !== null &&
     typeof err === "object" &&
     "code" in err &&
     "errorInfo" in err &&
     "codePrefix" in err &&
-    // oxlint-disable-next-line no-unsafe-member-access
     typeof err.errorInfo === "object" &&
-    // oxlint-disable-next-line no-unsafe-member-access
+    err.errorInfo !== null &&
     "code" in err.errorInfo &&
-    // oxlint-disable-next-line no-unsafe-member-access
     "message" in err.errorInfo
   );
 }

frontend/src/ts/commandline/util.ts

@@ -10,7 +10,7 @@ import {
 } from "./commandline-metadata";
 import { Command } from "./types";
 import * as ConfigSchemas from "@monkeytype/schemas/configs";
-import { z, ZodSchema } from "zod";
+import { z, ZodSchema, ZodFirstPartySchemaTypes } from "zod";
 
 function getOptions<T extends ZodSchema>(schema: T): undefined | z.infer<T>[] {
   if (schema instanceof z.ZodLiteral) {
@@ -28,7 +28,6 @@ function getOptions<T extends ZodSchema>(schema: T): undefined | z.infer<T>[] {
 }
 
 export function buildCommandForConfigKey<
-  // oxlint-disable-next-line no-unnecessary-type-parameters
   K extends keyof CommandlineConfigMetadataObject,
 >(key: K): Command {
   const configMeta = configMetadata[key];
@@ -120,8 +119,7 @@ function buildCommandWithSubgroup<K extends keyof ConfigSchemas.Config>(
 
   if (values === undefined) {
     throw new Error(
-      //@ts-expect-error todo
-      `Unsupported schema type for key "${key}": ${schema._def.typeName}`,
+      `Unsupported schema type for key "${key}": ${(schema as ZodFirstPartySchemaTypes)._def.typeName}`,
     );
   }
   const list = values.map((value) =>

frontend/src/ts/components/common/ChartJs.tsx

@@ -31,8 +31,9 @@ export function ChartJs<T extends ChartType, TData = DefaultDataPoint<T>>(
   let chart: ChartWithUpdateColors<T, TData> | undefined;
 
   onMount(() => {
-    //oxlint-disable-next-line no-non-null-assertion
-    chart = new ChartWithUpdateColors(canvasEl()!.native, {
+    const canvas = canvasEl();
+    if (canvas === undefined) return;
+    chart = new ChartWithUpdateColors(canvas.native, {
       type: props.type,
       data: props.data,
       options: props.options,

frontend/src/ts/db.ts

@@ -38,14 +38,11 @@ let dbSnapshot: Snapshot | undefined;
 const firstDayOfTheWeek = getFirstDayOfTheWeek();
 
 export class SnapshotInitError extends Error {
-  constructor(
-    message: string,
-    public responseCode: number,
-  ) {
+  public responseCode: number;
+
+  constructor(message: string, responseCode: number) {
     super(message);
     this.name = "SnapshotInitError";
-    // TODO INVESTIGATE
-    // oxlint-disable-next-line
     this.responseCode = responseCode;
   }
 }

frontend/src/ts/popups/video-ad-popup.ts

@@ -1,5 +1,3 @@
-/* oxlint-disable no-unsafe-call */
-/* oxlint-disable no-unsafe-member-access */
 import * as Notifications from "../elements/notifications";
 import * as AdController from "../controllers/ad-controller";
 import * as Skeleton from "../utils/skeleton";
@@ -44,7 +42,8 @@ export async function show(): Promise<void> {
         el.show();
       },
       onComplete: () => {
-        //@ts-expect-error 3rd party ad code
+        // @ts-expect-error 3rd party ad code
+        // oxlint-disable-next-line no-unsafe-call no-unsafe-member-access
         window.dataLayer.push({ event: "EG_Video" });
       },
     });

frontend/src/ts/utils/async-modules.ts

@@ -10,7 +10,6 @@ export async function getDevOptionsModal(): Promise<
 > {
   try {
     showLoaderBar();
-    // oxlint-disable-next-line import/no-unresolved
     const module = await import("../modals/dev-options.js");
     hideLoaderBar();
     return module;

frontend/src/ts/utils/misc.ts

@@ -176,8 +176,6 @@ type LastIndex = {
   lastIndexOfRegex(regex: RegExp): number;
 } & string;
 
-// TODO INVESTIGATE IF THIS IS NEEDED
-// oxlint-disable-next-line no-extend-native
 (String.prototype as LastIndex).lastIndexOfRegex = function (
   regex: RegExp,
 ): number {
@@ -596,13 +594,11 @@ export function promiseWithResolvers<T = void>(): {
     ): Promise<TResult1 | TResult2> {
       return currentPromise.then(onfulfilled, onrejected);
     },
-    // oxlint-disable-next-line promise-function-async
     async catch<TResult = never>(
       onrejected?: ((reason: unknown) => TResult | PromiseLike<TResult>) | null,
     ): Promise<T | TResult> {
       return currentPromise.catch(onrejected);
     },
-    // oxlint-disable-next-line promise-function-async
     async finally(onfinally?: (() => void) | null): Promise<T> {
       return currentPromise.finally(onfinally);
     },

frontend/src/ts/utils/results.ts

@@ -20,7 +20,7 @@ export async function syncNotSignedInLastResult(uid: string): Promise<void> {
 
   //TODO - this type cast was not needed before because we were using JSON cloning
   // but now with the stronger types it shows that we are forcing completed event
-  // into a snapshot result - might not cuase issues but worth investigating
+  // into a snapshot result - might not cause issues but worth investigating
   const result = structuredClone(
     notSignedInLastResult,
   ) as unknown as SnapshotResult<Mode>;

packages/release/src/index.js

@@ -1,5 +1,3 @@
-// idk why its failing to resolve
-// oxlint-disable-next-line import/no-unresolved
 import { Octokit } from "@octokit/rest";
 import { execSync } from "child_process";
 import dotenv from "dotenv";
@@ -263,14 +261,12 @@ const main = async () => {
     const name = readlineSync.question(
       "Enter preview channel name (default: preview): ",
     );
-    // oxlint-disable-next-line prefer-nullish-coalescing
-    const channelName = name.trim() || "preview";
+    const channelName = name.trim() ?? "preview";
 
     const expirationTime = readlineSync.question(
       "Enter expiration time (e.g., 2h, default: 1d): ",
     );
-    // oxlint-disable-next-line prefer-nullish-coalescing
-    const expires = expirationTime.trim() || "1d";
+    const expires = expirationTime.trim() ?? "1d";
 
     console.log(
       `Deploying frontend preview to channel "${channelName}" with expiration "${expires}"...`,

packages/schemas/src/users.ts

@@ -260,7 +260,7 @@ export const UserSchema = z.object({
   uid: z.string(), //defined by firebase, no validation should be applied
   addedAt: z.number().int().nonnegative(),
   personalBests: PersonalBestsSchema,
-  lastReultHashes: z.array(z.string()).optional(), //todo: fix typo (its in the db too)
+  lastReultHashes: z.array(z.string()).optional(), //TODO: fix typo (it's in the db too)
   completedTests: z.number().int().nonnegative().optional(),
   startedTests: z.number().int().nonnegative().optional(),
   timeTyping: z

packages/tsup-config/src/index.ts

@@ -2,9 +2,7 @@ import { defineConfig, Options } from "tsup";
 
 export function extendConfig(
   customizer?: (options: Options) => Options,
-  // tsup uses MaybePromise which is not exported
-  // oxlint-disable-next-line no-explicit-any
-): (options: Options) => any {
+): (options: Options) => unknown {
   return (options) => {
     const overrideOptions = customizer?.(options);
     const config: Options = {

packages/util/src/json.ts

@@ -31,9 +31,7 @@ export function parseWithSchema<T extends z.ZodTypeAny>(
     if (fallback === undefined) {
       throw new Error(`Invalid JSON: ` + error.message);
     }
-    // todo fix me
-    // oxlint-disable-next-line no-unsafe-return
-    return fallback as z.infer<T>;
+    return fallback as unknown;
   }
 
   const safeParse = schema.safeParse(jsonParsed);
@@ -60,9 +58,7 @@ export function parseWithSchema<T extends z.ZodTypeAny>(
           .join(", ")}`,
       );
     }
-    // todo fix me
-    // oxlint-disable-next-line no-unsafe-return
-    return fallback as z.infer<T>;
+    return fallback as unknown;
   }
 
   return safeParseMigrated.data as T;

vitest.config.ts

@@ -47,7 +47,6 @@ function convertTests(
 function copySolidPlugin(config: UserWorkspaceConfig): void {
   if (!config.plugins) return;
   config.plugins
-    //@ts-expect-error this is fine
-    .filter((it) => it["name"] === "solid")
+    .filter((it) => it?.["name"] === "solid")
     .forEach((it) => globalPlugins.push(it));
 }