Skip to content

fix(test-config): some layout and state issues (@byseif21) #7500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
byseif21 wants to merge 4 commits into
base: master
Choose a base branch
from
+8 −11
Open

fix(test-config): some layout and state issues (@byseif21) #7500

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ff3b46
fix(test-config): clear animated width to prevent some layout issues
byseif21 Feb 12, 2026
3436b2a
fix missmatch, lost length highlighting
byseif21 Feb 12, 2026
43a2c9c
cleanup redundant call
byseif21 Feb 12, 2026
178cfdc
refactor
byseif21 Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions frontend/src/ts/test/test-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ export async function instantUpdate(): Promise<void> {
qs("#testConfig .customText")?.show();
}

updateActiveExtraButtons("quoteLength", Config.quoteLength);
updateActiveExtraButtons("numbers", Config.numbers);
updateActiveExtraButtons("punctuation", Config.punctuation);
}
Expand All @@ -76,18 +75,14 @@ async function update(previous: Mode, current: Mode): Promise<void> {
if (previous === current) return;
updateActiveModeButtons(current);

let m2;

if (Config.mode === "time") {
m2 = Config.time;
} else if (Config.mode === "words") {
m2 = Config.words;
} else if (Config.mode === "quote") {
m2 = Config.quoteLength;
if (current === "time") {
updateActiveExtraButtons("time", Config.time);
} else if (current === "words") {
updateActiveExtraButtons("words", Config.words);
} else if (current === "quote") {
updateActiveExtraButtons("quoteLength", Config.quoteLength);
}

if (m2 !== undefined) updateActiveExtraButtons(Config.mode, m2);

const submenu = {
time: "time",
words: "wordCount",
Expand Down Expand Up @@ -251,6 +246,8 @@ async function update(previous: Mode, current: Mode): Promise<void> {
duration: animTime / 2,
ease: easing.out,
});

currentEl?.setStyle({ width: "" });
}

function updateActiveModeButtons(mode: Mode): void {
Expand Down