Fix Caps Lock indicator inversion on initial load#7483
Fix Caps Lock indicator inversion on initial load#7483harikrishna0315 wants to merge 2 commits intomonkeytypegame:masterfrom
Conversation
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and also include the author name at the end inside parenthesis. It looks like your proposed title needs to be adjusted. Details: A correct version would look something like: feat: add new feature (@github_username) |
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
|
Hi! The CI is asking for a Conventional Commits–style PR title. Could a maintainer please rename this PR to: fix(caps-warning): correct Caps Lock indicator inversion (@harikrishna0315) Thanks! |
|
hi @harikrishna0315 , thank you for your contribution. There is already a PR #7478 fixing this issue |
What was fixed
The Caps Lock indicator could become inverted when the page was loaded with Caps Lock already enabled, because the state was toggled instead of synced.
What changed
caps-warning.tsto prioritizeevent.getModifierState("CapsLock")getModifierStateis unavailableVerification