feat: add practice typing mode (no stats, xp, or pb) (@Vishal27alpha) by Vishal27alpha · Pull Request #7482 · monkeytypegame/monkeytype

Vishal27alpha · 2026-02-08T10:13:35Z

Description

What

Adds a new practice typing mode that allows users to type freely without affecting:

personal bests
XP
leaderboards
result history

Why

This enables low-pressure practice sessions while preserving competitive integrity of stats.

How

Extended shared schemas to include practice mode
Backend ignores practice results for persistence, XP, PB, and leaderboards
Frontend hides practice mode from result filters

Notes

API response shape remains unchanged
No database or contract changes required

Relevant files:

packages/schemas/src/shared.ts
backend/src/api/controllers/result.ts
frontend/src/ts/constants/default-result-filters.ts

github-actions · 2026-02-08T10:15:18Z

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

Copilot

Pull request overview

Adds a new practice typing mode intended for “no-stats” sessions, wiring it through shared mode schemas, backend result submission, and default frontend result filters.

Changes:

Extend shared mode/schema typing to include practice.
Backend: special-case practice in result submission (skip PB checks, skip DB insert, XP=0).
Frontend: default result filters mark practice as excluded.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
packages/schemas/src/shared.ts	Adds `practice` to the modes derived from `PersonalBestsSchema`.
backend/src/api/controllers/result.ts	Adds `practice` handling in result endpoints and XP calculation.
frontend/src/ts/constants/default-result-filters.ts	Excludes `practice` from default stats/result filtering.

packages/schemas/src/shared.ts

backend/src/api/controllers/result.ts

fehmer · 2026-02-08T10:22:17Z

You can already turn off result saving in the comand line result saving off.

Vishal27alpha · 2026-02-08T11:03:52Z

Thanks for pointing that out, I wasn’t aware this already existed via the command line.

That explains the gap I felt from a user perspective. Would you be open to reframing this PR to focus on exposing the existing practice mode in the UI (making it more discoverable), rather than adding new backend behavior?

Happy to adjust or close the PR based on your preference.

Miodec · 2026-02-08T13:25:57Z

Thanks for pointing that out, I wasn’t aware this already existed via the command line.

That explains the gap I felt from a user perspective. Would you be open to reframing this PR to focus on exposing the existing practice mode in the UI (making it more discoverable), rather than adding new backend behavior?

Happy to adjust or close the PR based on your preference.

Lets add a "result saving" settin to the account section in the settings page. In the description mention the word 'practice' so its easier to find. We should also add a 'practice' alias to the result saving commandline commands.

Vishal27alpha · 2026-02-08T14:04:06Z

Thanks a lot for the clarification that makes perfect sense.
I’m happy to try reworking this PR in that direction:

-Add a “Result saving” toggle in the Account section of Settings
-Explicitly mention practice in the UI copy for better discoverability
-Add practice as an alias to the existing command-line commands

I’ll start exploring this and update the PR accordingly, unless you’d prefer this to be handled as a separate PR instead.

Miodec · 2026-02-08T14:14:21Z

Thanks a lot for the clarification that makes perfect sense. I’m happy to try reworking this PR in that direction:

-Add a “Result saving” toggle in the Account section of Settings -Explicitly mention practice in the UI copy for better discoverability -Add practice as an alias to the existing command-line commands

I’ll start exploring this and update the PR accordingly, unless you’d prefer this to be handled as a separate PR instead.

Same pr is fine

github-actions · 2026-02-10T13:28:14Z

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

github-actions · 2026-02-11T08:24:54Z

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

github-actions · 2026-02-11T10:54:33Z

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

…tice alias

Vishal27alpha · 2026-02-13T05:36:03Z

Thanks for the review!
I’ve addressed the requested changes:

reverted the dev-auth change
removed unused modal/imports
updated the toggle implementation to match existing settings toggles
synced branch with latest master

All checks are passing now.

fehmer · 2026-02-13T09:14:53Z

hi @Vishal27alpha ,

i talked to @Miodec. There was a misunderstanding on where to put the setting. Mio requested the new setting to be added to the settings page under account settings, but that got moved. Please add it to the settings page after presents and before test difficulty. https://monkeytype.com/settings?highlight=difficulty

frontend/src/ts/commandline/lists/result-saving.ts

… command active state)

Vishal27alpha · 2026-02-13T12:40:30Z

Thanks for the clarification @fehmer!

I’ve moved the result saving setting to the main settings page (between presets and test difficulty) and added the missing active state for the command-line command.

frontend/src/html/pages/settings.html

frontend/src/ts/pages/account-settings.ts

frontend/src/ts/test/test-state.ts

…styles

…d of localStorage

frontend/src/ts/commandline/lists/result-saving.ts

frontend/src/ts/commandline/commandline-metadata.ts

frontend/src/ts/modals/simple-modals-base.ts

fehmer · 2026-02-14T20:57:52Z

Hi @Vishal27alpha , nice work 👍

To get rid of the lists/result-saving.ts and fully use the command-metadata this changes are needed:

in commandline/lists.ts
- add "resultsSavingEnabled" as first command in the behavior section, line 103
- remove the ResultSavingCommands from line 101 and remove the import
in elements/modes-notice.ts
- change the commands property from resultSaving to resultSavingEnabled, line 55

frontend/src/html/pages/account-settings.html

frontend/src/ts/modals/simple-modals.ts

frontend/src/ts/firebase.ts

fix(settings): move result saving to config and align command metadata - removed localStorage persistence - deleted result-saving command list - added alias to command metadata - reverted unnecessary modal changes#

Vishal27alpha · 2026-02-15T09:49:06Z

@fehmer I’ve reverted the requested changes and updated the implementation accordingly.

fehmer

nice work 👍

Vishal27alpha · 2026-02-15T12:23:41Z

Thanks! Really appreciate the review

Copilot AI review requested due to automatic review settings February 8, 2026 10:13

monkeytypegeorge added backend Server stuff frontend User interface or web stuff packages Changes in local packages labels Feb 8, 2026

github-actions bot added the waiting for review Pull requests that require a review before continuing label Feb 8, 2026

Copilot started reviewing on behalf of Vishal27alpha February 8, 2026 10:14 View session

github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Feb 8, 2026

Copilot AI reviewed Feb 8, 2026

View reviewed changes

packages/schemas/src/shared.ts Outdated Show resolved Hide resolved

backend/src/api/controllers/result.ts Outdated Show resolved Hide resolved

backend/src/api/controllers/result.ts Show resolved Hide resolved

backend/src/api/controllers/result.ts Outdated Show resolved Hide resolved

Vishal27alpha changed the title ~~feat: add practice typing mode (no stats, xp, or pb)~~ feat: add practice typing mode (no stats, xp, or pb) (@Vishal27alpha) Feb 8, 2026

github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Feb 8, 2026

Vishal27alpha force-pushed the feature/my-new-feature branch from 81ebe27 to 4aa931f Compare February 10, 2026 13:26

github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for update Pull requests or issues that require changes/comments before continuing labels Feb 10, 2026

github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for update Pull requests or issues that require changes/comments before continuing labels Feb 11, 2026

github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Feb 11, 2026

Vishal27alpha closed this Feb 11, 2026

Vishal27alpha force-pushed the feature/my-new-feature branch from e6ec9f7 to ac18f0f Compare February 11, 2026 19:10

github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Feb 11, 2026

feat(settings): add result saving toggle to account settings and prac…

10fcd31

…tice alias

monkeytypegeorge removed the backend Server stuff label Feb 13, 2026

Merge branch 'master' into feature/my-new-feature

417351e

fehmer reviewed Feb 13, 2026

View reviewed changes

frontend/src/ts/commandline/lists/result-saving.ts Outdated Show resolved Hide resolved

Vishal27alpha added 2 commits February 13, 2026 17:20

fix(settings): address review feedback (move setting location and add…

5405393

… command active state)

Merge branch 'master' into feature/my-new-feature

418900e

fehmer reviewed Feb 13, 2026

View reviewed changes

frontend/src/html/pages/settings.html Show resolved Hide resolved

fehmer reviewed Feb 13, 2026

View reviewed changes

frontend/src/ts/pages/account-settings.ts Outdated Show resolved Hide resolved

fehmer reviewed Feb 13, 2026

View reviewed changes

frontend/src/ts/test/test-state.ts Outdated Show resolved Hide resolved

Vishal27alpha added 3 commits February 14, 2026 01:23

refactor(settings): simplify result saving section and remove custom …

8cc349f

…styles

Merge branch 'master' into feature/my-new-feature

420de3f

fix(settings): persist result saving preference in user config instea…

29f6e0b

…d of localStorage

monkeytypegeorge added the packages Changes in local packages label Feb 14, 2026

Merge branch 'master' into feature/my-new-feature

042d6cf