-
Notifications
You must be signed in to change notification settings - Fork 532
Add Ruby 4.0 #2977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Ruby 4.0 #2977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the MongoDB Ruby driver to add support for Ruby 4.0 and JRuby 10.0, updating the testing infrastructure and test expectations accordingly. The changes prepare the driver for upcoming Ruby versions while maintaining backward compatibility.
Changes:
- Added Ruby 4.0 and JRuby 10.0 to the test matrix and build configurations
- Updated test expectations to use dynamic string interpolation instead of hardcoded values
- Added
ostructgem dependency for Ruby 3.4+ compatibility
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/mongo/monitoring/event/cmap/pool_created_spec.rb | Updated test to use dynamic options interpolation instead of hardcoded hash string |
| spec/mongo/client_construction_spec.rb | Updated error message tests to use dynamic BSON::Document interpolation for Ruby 4.0 compatibility |
| gemfiles/standard.rb | Added ostruct gem dependency for Ruby 3.4 and later |
| .evergreen/config/standard.yml.erb | Updated Ruby version lists to include Ruby 4.0, 3.4, and JRuby 10.0 |
| .evergreen/config/axes.yml.erb | Added Ruby 4.0 and JRuby 10.0 to build axes configuration |
| .evergreen/config.yml | Updated all test matrices to use Ruby 4.0 and JRuby 10.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jamis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I just left a few questions.
No description provided.