-
Notifications
You must be signed in to change notification settings - Fork 73
Raspberry Pi 5 Compatibility - The Sequel #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ion now for the Raspberry Pi 5.
…his time with the name change I'd missed before.
|
Thank you so much for this wonderful contribution! The addition of libgpiod support opens up crucial compatibility with Raspberry Pi 5, and your abstraction layer between BCM2835 and libgpiod is clean and effective. I’ve tested these changes on real hardware with no issues found, so we’re good to offer them right away. In the future, we may refine the documentation to clarify libgpiod installation steps and streamline examples. While the new |
|
Thank you for your kind words. I'm happy to help. As a now-retired software engineer, I need projects! 😄 One change I'd suggest that I didn't know how to do myself is a better test for whether or not to use libgpiod or not, better than looking at /proc/cpuinfo an checking for Raspberry Pi 5. I had been hoping that bcm2835_init() would fail if the BCM2835 library wasn't going to work. Unfortunately the initialization succeeds even when the library won't work after that. If you know a better way to test BCM2835 functionality that would be a good change. As for live-test.js, no biggie if you remove that. It was just a easy way for me to do my own testing. If you like I can, in a separate PR later, submit a more robust version that takes command line arguments for sensor type and pin. |
|
We really need to remove the |
To ensure our tests complete in an automated environment, we’ll remove live-test.js from the PR
I've removed the changes I'd had made for life on a different fork, as I suspect I'd need to do, to make this PR easier to accept.