Add verticalOffset function support #106#177
Open
tastyqbit wants to merge 2 commits intomohebifar:masterfrom
Open
Add verticalOffset function support #106#177tastyqbit wants to merge 2 commits intomohebifar:masterfrom
tastyqbit wants to merge 2 commits intomohebifar:masterfrom
Conversation
Specifically in react native navigation, the vertical offset is wrong on android (mohebifar#106). This commit allows passing in an async function that can be executed at runtime to decide vertical offset based on the specific devices statusbar and topbar height (in react native navigations case, using await Navigation.constants() )
Owner
|
Hey @tastyqbit , could you possibly add some explanation to the docs please? |
Author
|
@mohebifar done :) |
mohebifar
approved these changes
Jun 18, 2020
Owner
|
LGTM, there is just some lint issues that need to be fixed before merging |
Author
|
How can I see what the linter errors are? I can't see it in checks |
Owner
|
Here's the failing build: https://travis-ci.org/github/mohebifar/react-native-copilot/builds/698862581 you can also run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically in react native navigation, the vertical offset is wrong on android (#106). This commit allows passing in an async function that can be executed at runtime to decide vertical offset based on the specific devices statusbar and topbar height (in react native navigations case, using await Navigation.constants() )