More options to customize tooltip and additional navigator#122
Open
czystyl wants to merge 2 commits intomohebifar:masterfrom
Open
More options to customize tooltip and additional navigator#122czystyl wants to merge 2 commits intomohebifar:masterfrom
czystyl wants to merge 2 commits intomohebifar:masterfrom
Conversation
Owner
|
Same for this PR as well. Please do a rebase. Sorry for the delay 👀. Thank you for the great work. |
…to feat/tooltip-navigator
Contributor
Author
|
@mohebifar done :) |
|
@mohebifar Can we get this merged PLEEEEEEEEASE! :) |
Contributor
Author
|
@mohebifar Do you think that it should be merged? otherwise, I think we should close the PR :) Let me know if you want then I can try to resolve conflict. |
Owner
|
Hey @czystyl, so sorry for the very late reply. I know I asked you this once before and I forgot to merge after that 🤦♂️ , but there seems to be a conflict again, can you please rebase against master again so I can merge it? |
|
No update on this ? |
Contributor
Author
|
@mohebifar is this still needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added more a bit flexible way to customize the tooltip component, previously we have to deal with default behaviour but currently, we are able to build a full custom component.
The extra thing is the ability to render custom navigator which is similar to tooltip but can be placed anywhere.
All of these changes come from my current project.
I think it allows us to costumize component a bit more.
@mohebifar Let me know what do you think about these changes. I use it already and working fine 👍