Skip to content

Conversation

@jiaqixuac
Copy link
Contributor

@jiaqixuac jiaqixuac commented Jan 10, 2026

Update to install all the sub-packages inside diffsynth. Otherwise, the installed diffsynth package only contains __init__.py, but not contains other site-packages like core, diffusion, etc.

Update to install all the sub-packages inside diffsynth. Otherwise, the installed packages only contain __init__.py
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jiaqixuac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where Python package installations were incomplete, specifically for the diffsynth project. By modifying the package inclusion pattern in pyproject.toml, the change ensures that all necessary sub-packages are properly identified and bundled, leading to a fully functional installation of the project.

Highlights

  • Package Inclusion Fix: The pyproject.toml configuration has been updated to correctly include all sub-packages within the diffsynth directory during installation. Previously, only the top-level diffsynth package was being included, leading to incomplete installations.
  • Configuration Change: The include pattern under [tool.setuptools.packages.find] in pyproject.toml was changed from "diffsynth" to "diffsynth*" to enable recursive package discovery.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pyproject.toml file to correctly include all sub-packages of the diffsynth library during installation. The change from "diffsynth" to "diffsynth*" in the include pattern is functional, but I've suggested a more precise and idiomatic pattern to prevent potential conflicts and improve clarity, following setuptools best practices.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Artiprocher Artiprocher merged commit ffedb9e into modelscope:main Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants