Skip to content

Add DstLinkPath into FileMetadata for symlink #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FengyunPan2 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

Add DstLinkPath into FileMetadata for symlink #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions specs-go/v1/annotations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,7 @@ type FileMetadata struct {

// File type flag (e.g., regular file, directory, etc.)
Typeflag byte `json:"typeflag"`

// dstlinkpath is the destination link path for link type files (e.g., TypeLink, TypeSymlink)
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to Go's documentation conventions, comments for exported identifiers should start with the name of the identifier. Please update the comment to start with DstLinkPath instead of dstlinkpath for consistency and to adhere to standard Go style.

Suggested change
// dstlinkpath is the destination link path for link type files (e.g., TypeLink, TypeSymlink)
// DstLinkPath is the destination link path for link type files (e.g., TypeLink, TypeSymlink)

DstLinkPath string `json:"dstlinkpath,omitempty"`
Copy link
Member

@chlins chlins Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we should follow the name style of POSIX or golang standard package, Linkname is better is this case. FYI: https://pkg.go.dev/archive/tar

}
Loading