Skip to content

fix: bind prune and version flags to correct cobra command #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rishi-jat wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: bind prune and version flags to correct cobra command #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/prune.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ var pruneCmd = &cobra.Command{

// init initializes prune command.
func init() {
flags := rmCmd.Flags()
flags := pruneCmd.Flags()
flags.BoolVar(&pruneConfig.DryRun, "dry-run", false, "do not remove any blobs, just print what would be removed")
flags.BoolVar(&pruneConfig.RemoveUntagged, "remove-untagged", true, "remove untagged manifests")

Expand Down
2 changes: 1 addition & 1 deletion cmd/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ var versionCmd = &cobra.Command{

// init initializes version command.
func init() {
flags := rmCmd.Flags()
flags := versionCmd.Flags()

if err := viper.BindPFlags(flags); err != nil {
panic(fmt.Errorf("bind version flags to viper: %w", err))
Comment on lines +42 to 45
Copy link

@gemini-code-assist gemini-code-assist bot Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the version command has no flags defined, versionCmd.Flags() returns an empty flag set. The subsequent call to viper.BindPFlags is therefore a no-op. This block of code is redundant. For better code clarity, consider removing the entire init function as it currently has no effect.

Expand Down
Loading