Standardize logging to use logrus consistently across the repository#429
Draft
Standardize logging to use logrus consistently across the repository#429
Conversation
- Replace log alias (log "github.com/sirupsen/logrus") in mlflow package with direct "github.com/sirupsen/logrus" import - Convert all log.Printf/log.Println calls to proper logrus level methods (logrus.Infof, logrus.Debugf, logrus.Errorf, logrus.Warnf) - Add consistent "mlflow:" prefix to all mlflow log messages matching the existing "component: action" pattern used across the backend package - Replace stdlib log.Fatal with logrus.Fatal in cmd/root.go - Remove unused stdlib "log" import from cmd/root.go Co-authored-by: chlins <31262637+chlins@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor logging for consistent and standardized style
Standardize logging to use logrus consistently across the repository
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mlflow package aliased logrus as
logand usedlog.Printf/log.Println, whilecmd/root.goused the stdliblogpackage. Both deviated from the establishedlogrus.Levelf("component: action message")convention used everywhere else.Changes
pkg/modelprovider/mlflow/downloader.go,provider.go: Replacelog "github.com/sirupsen/logrus"alias with direct import. Convert alllog.Printf/log.Printlnto appropriate logrus level calls (Infof,Debugf,Errorf,Warnf) with"mlflow:"component prefix.cmd/root.go: Replace stdliblog.Fatal→logrus.Fatal, drop unused"log"import.Before/After
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.