Use SI units for size display

[chlins]

This pull request makes a minor adjustment to the progress bar formatting in internal/pb/pb.go. The change updates the units used for displaying file sizes and average speeds in the progress bar from binary (base-1024) to decimal (base-1000), ensuring consistency with other metrics.

• Progress bar display: Changed decor.SizeB1024 to decor.SizeB1000 for both counters and average speed decorators to use decimal units instead of binary units.

[gemini-code-assist]

Summary of Changes

Hello @chlins, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the display of data sizes and transfer speeds within the progress bar by switching from binary (base-1024) to decimal (base-1000) SI units. This change ensures that all reported metrics are consistent with standard SI prefixes, improving clarity and uniformity in data representation.

Highlights

• Progress Bar Unit Change: Updated file size and average speed display units in the progress bar from binary (base-1024) to decimal (base-1000) for consistency.

Changelog

• internal/pb/pb.go
  • Changed decor.SizeB1024 to decor.SizeB1000 for counters.
  • Changed decor.SizeB1024 to decor.SizeB1000 for average speed decorators.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to switch the progress bar display to use SI units (base-1000) instead of binary units (base-1024). While the intent is good, the implementation has a couple of issues that prevent it from working as expected.

My review points out that the usage of decor.SizeB1000(0) is incorrect and effectively results in no change from decor.SizeB1024. I've suggested using the decor.SizeB1000 constant directly.

Additionally, I've identified an inconsistency where the total size on completion would be displayed in binary units due to humanize.Bytes, contradicting the goal of the PR. I've suggested a simplification that resolves this and ensures consistent unit display throughout the progress bar's lifecycle.