Closed
Conversation
- creating a new child node had yielded a :$id:$name role which had led to duplicate caches entries in ReactiveINodeJS - added regression test for it
Contributor
Test Results146 files 146 suites 44m 16s ⏱️ Results for commit 5fe3001. ♻️ This comment has been updated with latest results. |
- to make sure we don't register the languages in one and wrap the nodes in another registry - the issue sometimes shows up when depending on model-client, ts-model-api and vue-model-api (sometimes causing multiple instances of the same js package) - avoids not finding concepts albeit them being registered
- ESNext produces ES Modules (ESM) - eases bundling it in vite projects with moduleResolution: bundler - ESM allows treeshaking the assembled projects, reducing their file size
abstraktor
force-pushed
the
fix/reactivity-with-roles
branch
from
15947e0 to
5fe3001
Compare
Collaborator
Author
|
I was hunting ghosts here. The issue is already solved since 17.0.2. I extraced code quality improvements into #2290 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes