[RFC] refactor: extract task orchestration from Protocol into TaskManager #1449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c76a53b The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
felixweinberger
changed the title
felixweinberger
force-pushed
the
fweinberger/extract-tasks-from-protocol
branch
from
c3104d6 to
b783fcd
Compare
felixweinberger
force-pushed
the
fweinberger/extract-tasks-from-protocol
branch
5 times, most recently
from
1cf942d to
adf1507
Compare
Extract all task-related logic from Protocol into a dedicated TaskManager class with consolidated lifecycle API and NullTaskManager (Null Object pattern). Protocol delegates to TaskManager via 4 lifecycle methods: - processInboundRequest: context extraction + function wrapping - processOutboundRequest: metadata augmentation + queue routing - processInboundResponse: side-channel handling + progress preservation - processOutboundNotification: task-related notification routing NullTaskManager provides no-op defaults, eliminating all conditional checks in Protocol.
felixweinberger
force-pushed
the
fweinberger/extract-tasks-from-protocol
branch
from
adf1507 to
c76a53b
Compare
Comment on lines
+183
to
+185
| return { | ||
| ...task | ||
| } as Result; |
Contributor
There was a problem hiding this comment.
Does Task not satisfy GetTaskResult already?
Comment on lines
+181
to
+182
| // Per spec: tasks/get responses SHALL NOT include related-task metadata | ||
| // as the taskId parameter is the source of truth |
Contributor
There was a problem hiding this comment.
nit: I don't think this comment is relevant here?
Contributor
|
Does this affect how task tools are registered and executed as well? It doesn't look like it does, but I just wanted to verify that first - I believe this supersedes #1315, but I'm unsure if it supersedes #1332 as well or not. Looks good overall though, I have similar problems in the Java SDK (modelcontextprotocol/java-sdk#755) and will probably copy part of this approach over there. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts experimental task orchestration logic from Protocol into a dedicated TaskManager class.
Protocol.ts drops from 1,736 to 992 lines. Task handler registration, message queuing, polling, and state management now live in TaskManager.
Protocol delegates through 5 lifecycle methods (
processInboundRequest,processOutboundRequest,processInboundResponse,processOutboundNotification,onClose) and a NullTaskManager provides no-op defaults when tasks are not configured.Motivation and Context
Task logic was spread across every major Protocol method, making it hard to reason about either concern independently. Since tasks are experimental, this isolation makes Protocol easier to maintain.
Breaking Changes
ProtocolOptions.taskStore/taskMessageQueue/ etc. moved underProtocolOptions.tasks?: TaskManagerOptionsTypes of changes
Checklist