Conversation
evalstate
requested review from
cliffhall and
olaservo
and removed request for
cliffhall
evalstate
force-pushed
the
feat/url-elicitation
branch
from
28bd5a0 to
224b6ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add URL Elicitation cases (normal
ElicitationRequest+-32042error style).Description
Opening for discussion -- this covers the basic case; I wonder do we want the ElicitationRequest to block and send a callback URL? Happy to add this, but wanted to discuss with @olahungerford @cliffhall before going that far.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context