fix(memory): allow additional properties in entity/relation schemas #3161
+24
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added .passthrough() to EntitySchema and RelationSchema to allow entities with extra properties to be read without schema validation errors. This fixes the issue where read_graph fails when the stored memory.jsonl contains entities with non-standard properties. Fixes modelcontextprotocol#3144 Signed-off-by: majiayu000 <1835304752@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.passthrough()toEntitySchemaandRelationSchemaProblem
When
memory.jsonlcontains entities with extra properties (e.g.,custom_id), theread_graphtool fails with:Solution
Using Zod's
.passthrough()allows the schema to accept additional properties while still validating required fields.Fixes #3144