Skip to content

Conversation

@varunkasyap
Copy link
Contributor

@varunkasyap varunkasyap commented Dec 21, 2025

Reference issue (if any)

Fixes #13550.

What does this implement/fix?

Fixes a crash when reading Eyelink ASCII files whose first recording block contains no sample data. The reader now handles this edge case and includes a test.

Additional information

Test suite passed in my local
image

@varunkasyap varunkasyap marked this pull request as draft December 21, 2025 12:38
@varunkasyap varunkasyap force-pushed the fix-eyelink-empty-trial branch from edeccb6 to 2ab0800 Compare December 21, 2025 14:20
@varunkasyap
Copy link
Contributor Author

Hey, I couldn’t understand the reason for the failing checks. Can someone please explain?

@varunkasyap varunkasyap marked this pull request as ready for review December 21, 2025 14:51
@varunkasyap
Copy link
Contributor Author

Hey, just wanted to check why the welcome bot didn’t get triggered for my PR?

@scott-huberty
Copy link
Contributor

Thanks @varunkasyap ! I will take a look this week.

@scott-huberty
Copy link
Contributor

Hey @

Hey, I couldn’t understand the reason for the failing checks. Can someone please explain?

Short answer is that you need to create a CircleCI account. if you sign in to CircleCI with your GitHub account, then the CI will be able to confirm that there is a CircleCI account associated with your GitHub username, and the check should run.

in MNE-Python, we use Github Actions to run some of our CI's, and we use CircleCI to run some CI's. For security reasons, we prevent PRs from users who dont have CircleCI accounts from triggering CircleCI hosted tests.

@varunkasyap varunkasyap force-pushed the fix-eyelink-empty-trial branch from 521a72f to 0f1d846 Compare December 24, 2025 05:36
@varunkasyap
Copy link
Contributor Author

Short answer is that you need to create a CircleCI account. if you sign in to CircleCI with your GitHub account, then the CI will be able to confirm that there is a CircleCI account associated with your GitHub username, and the check should run.

Thanks @scott-huberty

I think this PR is now ready for review. Do I need to mention this change somewhere in the docs?

@drammock
Copy link
Member

Do I need to mention this change somewhere in the docs?

please add a changelog entry doc/changes/dev/13555.bugfix.rst stating that read_raw_eyelink no longer raises an error for Eyelink files with an empty first recording block. See other files in that folder for examples of how to format the changelog entry (including crossrefs on function names, linking to the PR, and your name formatted with newcontrib role). If you haven't yet done so, you'll need to add an entry for yourself (alphabetically please) to doc/changes/names.inc too.

@varunkasyap
Copy link
Contributor Author

varunkasyap commented Dec 26, 2025

Hi @drammock ,
Made minor typo fixes in mne/io/eyelink/_utils.py in the same PR. I didn’t want to create spam PRs for documentation fixes, and I believe a changelog is not needed for such minor typo fixes.

Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM. @scott-huberty do you have time to review this one? Please pay special attention to the test, as that's the part I'm least confident about just from reading the code (I'm not often looking at Eyelink ASCII files these days).

@@ -0,0 +1 @@
Fix bug where :func:`mne.io.read_raw_eyelink` raised an error when reading Eyelink files with an empty first recording block, by :newcontrib:`Varun Kasyap` (:gh:`13555`). No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content of the newcontrib role must match the entry in names.inc exactly (other than capitalization, which is ignored). See error:

[towncrier-fragments]:14: ERROR: Indirect hyperlink target "new contributor Varun Kasyap" refers to target "varun kasyap", which does not exist. [docutils]
[towncrier-fragments]:14: ERROR: Unknown target name: "varun kasyap". [docutils]

So either add Pentamaraju here, or remove it from names.inc

@varunkasyap varunkasyap force-pushed the fix-eyelink-empty-trial branch from bf7c901 to cb45659 Compare December 26, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

read_raw_eyelink() cannot handle empty first trial

3 participants