-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
FIX: handle empty first Eyelink recording block #13555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
edeccb6 to
2ab0800
Compare
|
Hey, I couldn’t understand the reason for the failing checks. Can someone please explain? |
|
Hey, just wanted to check why the welcome bot didn’t get triggered for my PR? |
|
Thanks @varunkasyap ! I will take a look this week. |
2ab0800 to
521a72f
Compare
|
Hey @
Short answer is that you need to create a CircleCI account. if you sign in to CircleCI with your GitHub account, then the CI will be able to confirm that there is a CircleCI account associated with your GitHub username, and the check should run. in MNE-Python, we use Github Actions to run some of our CI's, and we use CircleCI to run some CI's. For security reasons, we prevent PRs from users who dont have CircleCI accounts from triggering CircleCI hosted tests. |
521a72f to
0f1d846
Compare
Thanks @scott-huberty I think this PR is now ready for review. Do I need to mention this change somewhere in the docs? |
please add a changelog entry |
0f1d846 to
55b013c
Compare
55b013c to
bf7c901
Compare
|
Hi @drammock , |
drammock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM. @scott-huberty do you have time to review this one? Please pay special attention to the test, as that's the part I'm least confident about just from reading the code (I'm not often looking at Eyelink ASCII files these days).
doc/changes/dev/13555.bugfix.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Fix bug where :func:`mne.io.read_raw_eyelink` raised an error when reading Eyelink files with an empty first recording block, by :newcontrib:`Varun Kasyap` (:gh:`13555`). No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content of the newcontrib role must match the entry in names.inc exactly (other than capitalization, which is ignored). See error:
[towncrier-fragments]:14: ERROR: Indirect hyperlink target "new contributor Varun Kasyap" refers to target "varun kasyap", which does not exist. [docutils]
[towncrier-fragments]:14: ERROR: Unknown target name: "varun kasyap". [docutils]
So either add Pentamaraju here, or remove it from names.inc
bf7c901 to
cb45659
Compare
Reference issue (if any)
Fixes #13550.
What does this implement/fix?
Fixes a crash when reading Eyelink ASCII files whose first recording block contains no sample data. The reader now handles this edge case and includes a test.
Additional information
Test suite passed in my local
