Skip to content

Comments

fft2#344

Merged
lpatiny merged 4 commits intomainfrom
fft2
Feb 19, 2026
Merged

fft2#344
lpatiny merged 4 commits intomainfrom
fft2

Conversation

@lpatiny
Copy link
Member

@lpatiny lpatiny commented Feb 19, 2026

  • feat: add reimArrayFFT
  • feat: add inPlace for reimArrayFFT and reimFFT

@lpatiny lpatiny mentioned this pull request Feb 19, 2026
Closed
@lpatiny
Copy link
Member Author

lpatiny commented Feb 19, 2026

Here are the results of the benchmark. reimArrayFFT is 2 times after that the equivalent reimFFT on the same number of spectra. This test case was on 10 spectra and we expect a better result for NMR 2D processing.

reimFFT (loop): 5.008s
  3060 total FFTs, 10 spectra × 306 rounds
  1.637 ms per FFT

reimFFT inPlace (loop): 5.007s
  3140 total FFTs, 10 spectra × 314 rounds
  1.595 ms per FFT

reimArrayFFT: 5.006s
  6090 total FFTs, 10 spectra × 609 rounds
  0.822 ms per FFT

reimArrayFFT inPlace: 5.002s
  6510 total FFTs, 10 spectra × 651 rounds
  0.768 ms per FFT

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.92%. Comparing base (b829991) to head (6973469).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   96.88%   96.92%   +0.03%     
==========================================
  Files         190      192       +2     
  Lines        3601     3641      +40     
  Branches      910      922      +12     
==========================================
+ Hits         3489     3529      +40     
  Misses        108      108              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpatiny lpatiny merged commit 9cda6b5 into main Feb 19, 2026
11 checks passed
@lpatiny lpatiny deleted the fft2 branch February 19, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant