-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Tensor scale nvfp4 #3022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nastya236
wants to merge
31
commits into
ml-explore:main
Choose a base branch
from
nastya236:tensor-scale-nvfp4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tensor scale nvfp4 #3022
+672
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into tensor-scale-nvfp4
awni
reviewed
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add per tensor scale for
nvfp4quantization forcudaandcpu.qqmm,quantize,dequantizeinputs optional 1Dfloat32array (global_scale) ifmode == "nvfp4".Tensor scale will help with small inputs:
AbsMaxreduction type andmx.absmaxopFor
nvfp4training we will compute amax often. So now there is a new reduction type in whichabsis applied inside theall_reducekernel.Probably there is a way to do it better.
TODO: we probably want to support
global_scalein metal as well but it requires changing all quantized operations.