agent sessions - more sections tweaks #283364
Open
+194
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the agent sessions grouping system to use more granular time-based sections. The previous two-tier system (Recent/Old) is replaced with a four-tier system (Today/Week/Older/Archived) for better organization and user experience.
Key Changes:
- Renamed and added section types:
Recent→Today,Old→Older, and introduced newWeeksection - Updated session grouping logic to use calendar day boundaries for "Today" and a 7-day threshold for "Week"
- Updated all tests to reflect the new section naming and thresholds
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsModel.ts | Updated AgentSessionSection enum with new values: Today, Week, Older (replacing Recent and Old) |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts | Refactored session grouping logic to support three non-archived sections with calendar-day-based "Today" detection and 7-day "Week" threshold; updated localization keys |
| src/vs/workbench/contrib/chat/test/browser/agentSessionsDataSource.test.ts | Updated test constants, names, assertions, and test data to match new section structure; added tests for "Week" section behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.