Ignore invalid files when looking for copilot-instructions.md #283322
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a defense-in-depth fix for handling invalid files when searching for copilot-instructions.md files in workspace folders. While the original bug mentioned in issue #261610 is already protected elsewhere in the code, this change adds an additional safety layer by validating that discovered paths reference actual files rather than directories or symlinks.
Key changes:
- Replaced
fileService.exists()withfileService.stat()to enable file type validation - Added
stat.isFilecheck to filter out non-file resources (directories, symlinks) - Added try-catch error handling to gracefully skip inaccessible or invalid paths
- Added trace logging for debugging when files are skipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261610
Technically the bug is already fixed as I am unable to repro with symlinks (code reading from such files is already protected).
This PR fixes one place which does not have the protection, although it is defence in depth as well since it works without this change.